Skip to content

Conversation

jman116
Copy link

@jman116 jman116 commented Aug 12, 2025

Changes

I found that when opening objects in our SRCPFs, it's wildly unpredictable with how long it takes to open, ranging from nearly instantly to minutes.
The Code for i log shows that the last command sent before it seems to get stuck loading is:

const [row] = await this.runSQL(`SELECT IASP_NUMBER FROM TABLE(QSYS2.LIBRARY_INFO('${this.sysNameInAmerican(library)}'))`);

IBM documentation states that calculating library_size can take a long time which our 20k+ object library seems to agree with:

Image

By swapping to DETAILED_INFO=>'NO', the fetch time becomes nearly instantaneously, and it still provides IASP_NUMBER:

Image Image

Made the necessary change and have been running it all day, with great success.

This is my first pull request, if I messed something up please let me know!

How to test this PR

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@jman116 jman116 marked this pull request as ready for review August 12, 2025 22:40
@worksofliam
Copy link
Member

@jman116 this is awesome. I will run the tests and try it tomorrow. Did you also run the test cases for this? npm run test

@jman116 jman116 temporarily deployed to testing_environment August 13, 2025 07:03 — with GitHub Actions Inactive
@sebjulliand sebjulliand requested a review from a team August 13, 2025 07:04
@jman116
Copy link
Author

jman116 commented Aug 13, 2025

@worksofliam I did not run the test suite, sorry. Just compiled and used the application throughout the day as my testing. Didn't encounter any errors.

@jman116
Copy link
Author

jman116 commented Aug 21, 2025

@worksofliam Is there anything on my end that I must do to get this pull request approved, or is it just waiting for a release?

@worksofliam
Copy link
Member

@jman116 No rush on your end. The team is all just a little bit busy at the moment - we will for sure merge it when we're available!

@worksofliam
Copy link
Member

@jman116 I am looking at this today. Any chance you can fix the conflicts? Thanks!

Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Let's get that single conflict fixed and then I will merge.

Thanks!

@jman116
Copy link
Author

jman116 commented Aug 25, 2025

@worksofliam Got it resolved!

@worksofliam worksofliam merged commit fdf6d55 into codefori:master Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants