Removed netstat_job_info calls

[sebjulliand]

Changes

This PR removes the queries to netstat_job_info as it requires *IOSYSCFG special authority since 7.6.
It was used to retrieve the debug server and service job information.

The queries are replaced by queries to job_info, using the service and server job names (as they are not supposed to change).

Finally, a direc call to updateConnectedBar has been removed as it turns out it's already called twice when the user connects (indirect calls).

How to test this PR

1. Connect
2. Check the debugger status
3. Ensure debug service can't be started from Code for i anymore
4. Check that the service status is correctly updated once started/stopped from iNav and refreshed in Code for i

Checklist

• have tested my change

[github-actions]

👋 A new build is available for this PR based on 3c7d43c.

• Download here.
• Read more about how to test

[worksofliam]

@SanjulaGanepola @mkwan01 any chance one of you can test this PR? Neither @sebjulliand or I have a debug service working. It requires a 7.6 vm.

[mkwan01]

Our 7.6 machine requires an update to the Navigator. I will test the changes after the update.

[SanjulaGanepola]

The PR also removes the start/stop actions on the Debug Service item in the IBM i Debugger view as it's now iNav reponsibility to manage the debug service.

@sebjulliand While this is true, I personally like having the stop/start actions in VS Code for convenience. If we do want to still promote users to use iNav instead for this, can we add a VS Code Setting to enable these options (can be disabled by default)? What do you think?

Unless there is in fact a difference in how it is started in iNav vs VS Code?

[mkwan01]

@sebjulliand @SanjulaGanepola I also prefer to keep the start/stop actions, as it is more convenient to do everything inside VS Code, without switching to a Navigator browser. I am OK if this is controlled by a setting and it is disabled by default.

[sebjulliand]

@SanjulaGanepola @mkwan01 fair enough, I've put the start/stop actions back.
Back to you for approval. Thanks 😄

[SanjulaGanepola]

When testing this out, I noticed that there were constant calls to updateConnectedBar. One issue is that we are doing:

onCodeForIBMiConfigurationChange("connectionSettings", updateConnectedBar)

which means any time the user adds a filter, or really does a lot of the core tasks, we are going to constantly call isDebugEngineRunning which is overkill imo.

[sebjulliand]

which means any time the user adds a filter, or really does a lot of the core tasks, we are going to constantly call isDebugEngineRunning which is overkill imo.

@SanjulaGanepola yes, totally. We should address that in a separate PR.