Fix #484: skipping behavior for multi-location errors#485
Draft
kluhan wants to merge 2 commits intocodefori:mainfrom
Draft
Fix #484: skipping behavior for multi-location errors#485kluhan wants to merge 2 commits intocodefori:mainfrom
kluhan wants to merge 2 commits intocodefori:mainfrom
Conversation
Author
|
@worksofliam Could you help clarify the difference between |
worksofliam
reviewed
Mar 20, 2026
Member
worksofliam
left a comment
There was a problem hiding this comment.
To me it's like this:
@rpglint-skipskips both rules and indentation checks@rpglint-skip-rulesskips all rules but indentation@rpglint-skip-indentskils indent checking, but checks all other rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@rpglint-skipto properly suppress errors with multiple locations.pushErrorIfNotSkippedto simplify error handling across existing rules.Tests
Why It Matters
Previously, some errors (like variable casing) weren’t suppressed on second-pass checks. This unifies skip logic, ensures consistent suppression, and enables future directives like
@rpglint-skip: StringLiteralDupewithout extra complexity.