Skip to content

correctly order the dates for summary #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wittejm merged 1 commit into from
Jan 14, 2026
Merged

correctly order the dates for summary #1801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/backend/expungeservice/charges_summarizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,17 @@ def _get_case_has_ineligible_charge(case: Record):

@staticmethod
def _get_future_eligibility_label_on_case(case: Record):
# Filter to charges with a future eligibility date, excluding ineligible charges (date.max())
future_eligible_charges = [
charge for charge in case.charges
if charge.expungement_result.charge_eligibility.date_to_sort_label_by
and charge.expungement_result.charge_eligibility.date_to_sort_label_by != date.max()
]
if not future_eligible_charges:
return None
# Return the label of the charge with the latest date (case can't be expunged until all eligible charges are eligible)
date_sorted_charges = sorted(
case.charges,
key=lambda charge: charge.expungement_result.charge_eligibility.date_to_sort_label_by or date.max(),
future_eligible_charges,
key=lambda charge: charge.expungement_result.charge_eligibility.date_to_sort_label_by,
)
if date_sorted_charges[0].expungement_result.charge_eligibility.date_to_sort_label_by:
return date_sorted_charges[0].expungement_result.charge_eligibility.label
else:
return None
return date_sorted_charges[-1].expungement_result.charge_eligibility.label