Skip to content

recursive submodule fix #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

recursive submodule fix #2

wants to merge 4 commits into from

Conversation

vasily-codefresh
Copy link

this PR fixes:

  1. error status not reported
  2. recursive submodules

@vasily-codefresh
correct error exit status
871fc5b
@vasily-codefresh
fix recursive submodules
95e55b4 
currently we depend on a hack that uses sed to enforce https, not git for github.
this doesn't work for submodules.

re-doing this hack with a `git config` instead
@vasily-codefresh
it looks like we don't need ssh hack, as we don't use ssh
9c21e18
@vasily-codefresh
codestyle (4 spaces for indent, not a mix of 4 and 2)
0f30df7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vasily-codefresh