-
Notifications
You must be signed in to change notification settings - Fork 62
feat: adds retry logic for llm calls #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
kopekC
wants to merge
3
commits into
develop
from
pujol-cg-10967-implement-retry-with-backoff-for-llm-calls-on-rate-limit
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| """Retry utilities for handling rate limits and other transient errors.""" | ||
|
|
||
| import asyncio | ||
| import functools | ||
| import logging | ||
| import time | ||
| from typing import Any, Callable, TypeVar, cast | ||
|
|
||
| import anthropic | ||
| import openai | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| # Type variable for the decorator | ||
| T = TypeVar("T") | ||
|
|
||
|
|
||
| def retry_on_rate_limit(max_retries: int = 3, base_delay: float = 45.0) -> Callable[[Callable[..., T]], Callable[..., T]]: | ||
| """Decorator to retry functions on rate limit errors with exponential backoff. | ||
|
|
||
| Args: | ||
| max_retries: Maximum number of retry attempts | ||
| base_delay: Base delay in seconds between retries (will be multiplied by 2^retry_count) | ||
|
|
||
| Returns: | ||
| Decorated function with retry logic | ||
| """ | ||
|
|
||
| def decorator(func: Callable[..., T]) -> Callable[..., T]: | ||
| @functools.wraps(func) | ||
| def wrapper(*args: Any, **kwargs: Any) -> T: | ||
| retries = 0 | ||
| while True: | ||
| try: | ||
| return func(*args, **kwargs) | ||
| except (openai.RateLimitError, anthropic.RateLimitError) as e: | ||
| retries += 1 | ||
| if retries > max_retries: | ||
| logger.exception(f"Rate limit exceeded after {max_retries} retries. Giving up.") | ||
| raise | ||
|
|
||
| # Calculate delay with exponential backoff: base_delay * 2^(retry_count-1) | ||
| delay = base_delay * (2 ** (retries - 1)) | ||
| logger.warning(f"Rate limit hit. Retrying in {delay:.1f} seconds... (Attempt {retries}/{max_retries})") | ||
| time.sleep(delay) | ||
| except Exception as e: | ||
| # Re-raise other exceptions | ||
| raise | ||
|
|
||
| @functools.wraps(func) | ||
| async def async_wrapper(*args: Any, **kwargs: Any) -> T: | ||
| retries = 0 | ||
| while True: | ||
| try: | ||
| return await func(*args, **kwargs) | ||
| except (openai.RateLimitError, anthropic.RateLimitError) as e: | ||
| retries += 1 | ||
| if retries > max_retries: | ||
| logger.exception(f"Rate limit exceeded after {max_retries} retries. Giving up.") | ||
| raise | ||
|
|
||
| # Calculate delay with exponential backoff: base_delay * 2^(retry_count-1) | ||
| delay = base_delay * (2 ** (retries - 1)) | ||
| logger.warning(f"Rate limit hit. Retrying in {delay:.1f} seconds... (Attempt {retries}/{max_retries})") | ||
| await asyncio.sleep(delay) | ||
| except Exception as e: | ||
| # Re-raise other exceptions | ||
| raise | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here as well
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure |
||
|
|
||
| # Return the appropriate wrapper based on whether the function is async or not | ||
| if asyncio.iscoroutinefunction(func): | ||
| return cast(Callable[..., T], async_wrapper) | ||
| return cast(Callable[..., T], wrapper) | ||
|
|
||
| return decorator | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we raise a rate limit error here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure