Skip to content

fix: remote git repo doesn't need token if it's public repo #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christinewangcw merged 3 commits into from
Mar 7, 2025
Merged

fix: remote git repo doesn't need token if it's public repo #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbe4541
fix: remote git repo doesn't need token if it's public repo
christinewangcw Mar 7, 2025
3541cec
revert other changes
christinewangcw Mar 7, 2025
3a0b576
remvoe generate runer import step
christinewangcw Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,27 +80,13 @@ repos:
rev: 39.169.3
hooks:
- id: renovate-config-validator

- repo: https://github.com/astral-sh/uv-pre-commit
rev: "0.5.31"
hooks:
- id: uv-sync
args: ["--frozen", "--all-packages", "--all-extras"]

- repo: "local"
hooks:
# Disabled as part of LFS removal.
# - id: disallowed-words-check
# name: Check for disallowed words
# entry: scripts/disallowed-words-check.sh
# language: script
# files: '' # Check all files
- id: generate-runner-imports
name: Generate Runner Imports
entry: bash -c "uv run --frozen python -m codegen.gscli.cli generate runner-imports src/codegen/shared/compilation/function_imports.py"
language: system
pass_filenames: false
always_run: true

- repo: https://github.com/hukkin/mdformat
rev: 0.7.22 # Use the ref you want to point at
hooks:
Expand Down
4 changes: 2 additions & 2 deletions src/codegen/git/repo_operator/repo_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from codegen.git.clients.git_repo_client import GitRepoClient
from codegen.git.configs.constants import CODEGEN_BOT_EMAIL, CODEGEN_BOT_NAME
from codegen.git.repo_operator.local_git_repo import LocalGitRepo
from codegen.git.schemas.enums import CheckoutResult, FetchResult, SetupOption
from codegen.git.schemas.enums import CheckoutResult, FetchResult, RepoVisibility, SetupOption
from codegen.git.schemas.repo_config import RepoConfig
from codegen.git.utils.clone import clone_or_pull_repo, clone_repo, pull_repo
from codegen.git.utils.clone_url import add_access_token_to_url, get_authenticated_clone_url_for_repo_config, get_clone_url_for_repo_config, url_to_github
Expand Down Expand Up @@ -89,7 +89,7 @@ def repo_path(self) -> str:

@property
def remote_git_repo(self) -> GitRepoClient:
if not self.access_token:
if not self.access_token and self.repo_config.visibility != RepoVisibility.PUBLIC:
msg = "Must initialize with access_token to get remote"
raise ValueError(msg)

Expand Down
Loading