[CG-12126] Conditionals fix #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagel897
approved these changes
Mar 14, 2025
Contributor
bagel897
left a comment
bagel897
left a comment
There was a problem hiding this comment.
I feel like this is very hacky? But if it fixes stuff in prod and there are tests, go for it?
EdwardJXLi
approved these changes
Mar 14, 2025
README + run.py
<!-- Why is this change necessary? --> <!-- Please include a summary of the change --> <!-- How was the change tested? --> - [ ] I have added tests for my changes - [ ] I have updated the documentation or added new documentation as needed --------- Co-authored-by: tomcodgen <[email protected]>
# Motivation <!-- Why is this change necessary? --> # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [ ] I have added tests for my changes - [ ] I have updated the documentation or added new documentation as needed
# Motivation <!-- Why is this change necessary? --> # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [ ] I have added tests for my changes - [ ] I have updated the documentation or added new documentation as needed
…#821) ## Description This PR fixes an IndexError that occurs in the `CodeAgent.run()` method when handling AI messages with empty content lists. ### Problem The error occurs when trying to access `message.content[0]` but `message.content` is an empty list: ``` IndexError: list index out of range ``` ### Stack Trace ``` File "/root/app/modal_app/gen/slack/handlers.py", line 46, in handle_app_mention agent.run(prompt) File "/usr/local/lib/python3.12/site-packages/codegen/agents/code_agent.py", line 123, in run if isinstance(message, AIMessage) and isinstance(message.content, list) and "text" in message.content[0]: ~~~~~~~~~~~~~~~^^^ ``` ### Solution Added a check to verify that `message.content` is not empty before trying to access its first element: ```python if isinstance(message, AIMessage) and isinstance(message.content, list) and len(message.content) > 0 and "text" in message.content[0]: ``` This prevents the IndexError when `message.content` is an empty list. ### Testing This fix should prevent the IndexError when the CodeAgent receives an AIMessage with an empty content list. Co-authored-by: codegen-bot <[email protected]>
…rectory` # Motivation <!-- Why is this change necessary? --> # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [ ] I have added tests for my changes - [ ] I have updated the documentation or added new documentation as needed
## Description
This PR improves the error handling in the `RelaceEditTool` when a file
is not found. Instead of raising a `FileNotFoundError` exception, it now
returns a `RelaceEditObservation` with an error status and a helpful
message.
## Changes
- Modified the `relace_edit` function to return a
`RelaceEditObservation` with an error status when a file is not found
- Added a more descriptive error message that includes the full filepath
and suggests using the full filepath relative to the repository root
## Why
Previously, when a user provided an invalid filepath to the
`RelaceEditTool`, it would raise a `FileNotFoundError` exception that
wasn't properly passed back to the assistant as an observation. This
change ensures that file not found errors are handled consistently with
other errors and returned as observations, allowing the assistant to
handle them gracefully.
Fixes the issue where users would see errors like:
```
FileNotFoundError('File not found: codegen_agi.py')
```
instead of getting a helpful error message as part of the tool's
observation.
---------
Co-authored-by: codegen-bot <[email protected]>
Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
# Motivation <!-- Why is this change necessary? --> # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [ ] I have added tests for my changes - [ ] I have updated the documentation or added new documentation as needed
# Motivation <!-- Why is this change necessary? --> # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [ ] I have added tests for my changes - [ ] I have updated the documentation or added new documentation as needed
This PR updates the Relace Edit Tool URL from `dev-endpoint` to `endpoint` as requested. The change was made in `src/codegen/extensions/tools/relace_edit.py` to update the URL from: ``` https://codegen-instantapply.dev-endpoint.relace.run/v1/code/apply ``` to: ``` https://codegen-instantapply.endpoint.relace.run/v1/code/apply ``` This change routes the Relace Edit Tool to the warm servers instead of the cold-start servers, which should eliminate the 3-minute cold-start delay. Co-authored-by: codegen-bot <[email protected]>
a better solution would be to use graph QL to pull the repo plan features - this is a temporary one for eitan
# Motivation - More supported languages - Faster parse time - Lower memory usage # Content - Add feature flag to enable the Rust Version (pink) of the SDK, disabled by default - Add basic tests with it enabled # TODO: - Add more basic APIs to support more read operations (IE filepath) - Support edit operations - Synchronize database state - Expose and implement references
# Motivation <!-- Why is this change necessary? --> # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [ ] I have added tests for my changes - [ ] I have updated the documentation or added new documentation as needed
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tj-actions/changed-files](https://redirect.github.com/tj-actions/changed-files) | action | patch | `v45.0.7` -> `v45.0.8` | --- ### Release Notes <details> <summary>tj-actions/changed-files (tj-actions/changed-files)</summary> ### [`v45.0.8`](https://redirect.github.com/tj-actions/changed-files/releases/tag/v45.0.8) [Compare Source](https://redirect.github.com/tj-actions/changed-files/compare/v45.0.7...v45.0.8) #### What's Changed - Upgraded to v45.0.7 by [@​tj-actions-bot](https://redirect.github.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/2425](https://redirect.github.com/tj-actions/changed-files/pull/2425) - chore(config): migrate renovate config by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2427](https://redirect.github.com/tj-actions/changed-files/pull/2427) - chore(deps): lock file maintenance by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2426](https://redirect.github.com/tj-actions/changed-files/pull/2426) - chore(deps): update dependency prettier to v3.5.0 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2428](https://redirect.github.com/tj-actions/changed-files/pull/2428) - chore(deps): lock file maintenance by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2429](https://redirect.github.com/tj-actions/changed-files/pull/2429) - chore(deps): update dependency [@​types/node](https://redirect.github.com/types/node) to v22.13.2 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2432](https://redirect.github.com/tj-actions/changed-files/pull/2432) - chore(deps): update dependency prettier to v3.5.1 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2433](https://redirect.github.com/tj-actions/changed-files/pull/2433) - chore(deps): update dependency [@​types/node](https://redirect.github.com/types/node) to v22.13.4 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2434](https://redirect.github.com/tj-actions/changed-files/pull/2434) - fix(deps): update dependency [@​octokit/rest](https://redirect.github.com/octokit/rest) to v21.1.1 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2435](https://redirect.github.com/tj-actions/changed-files/pull/2435) - chore(deps): lock file maintenance by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2436](https://redirect.github.com/tj-actions/changed-files/pull/2436) - chore(deps): update dependency [@​types/node](https://redirect.github.com/types/node) to v22.13.5 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2439](https://redirect.github.com/tj-actions/changed-files/pull/2439) - chore(deps): update dependency prettier to v3.5.2 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2440](https://redirect.github.com/tj-actions/changed-files/pull/2440) - chore(deps): update dependency ts-jest to v29.2.6 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2441](https://redirect.github.com/tj-actions/changed-files/pull/2441) - chore(deps): lock file maintenance by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2442](https://redirect.github.com/tj-actions/changed-files/pull/2442) - chore(deps): update peter-evans/create-pull-request action to v7.0.7 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2443](https://redirect.github.com/tj-actions/changed-files/pull/2443) - chore(deps): update dependency eslint-config-prettier to v10.0.2 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2444](https://redirect.github.com/tj-actions/changed-files/pull/2444) - chore(deps): update dependency typescript to v5.8.2 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2446](https://redirect.github.com/tj-actions/changed-files/pull/2446) - chore(deps): update dependency [@​types/node](https://redirect.github.com/types/node) to v22.13.7 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2448](https://redirect.github.com/tj-actions/changed-files/pull/2448) - chore(deps): update dependency [@​types/lodash](https://redirect.github.com/types/lodash) to v4.17.16 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2449](https://redirect.github.com/tj-actions/changed-files/pull/2449) - chore(deps): update dependency [@​types/node](https://redirect.github.com/types/node) to v22.13.8 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2450](https://redirect.github.com/tj-actions/changed-files/pull/2450) - chore(deps): lock file maintenance by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2451](https://redirect.github.com/tj-actions/changed-files/pull/2451) - chore(deps): update dependency prettier to v3.5.3 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2453](https://redirect.github.com/tj-actions/changed-files/pull/2453) - chore(deps): update dependency [@​types/node](https://redirect.github.com/types/node) to v22.13.9 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2454](https://redirect.github.com/tj-actions/changed-files/pull/2454) - chore(deps): update peter-evans/create-pull-request action to v7.0.8 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2455](https://redirect.github.com/tj-actions/changed-files/pull/2455) - chore(deps): update dependency eslint-config-prettier to v10.1.0 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2457](https://redirect.github.com/tj-actions/changed-files/pull/2457) - chore(deps): update dependency eslint-config-prettier to v10.1.1 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2458](https://redirect.github.com/tj-actions/changed-files/pull/2458) - chore(deps): update dependency [@​types/node](https://redirect.github.com/types/node) to v22.13.10 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2459](https://redirect.github.com/tj-actions/changed-files/pull/2459) - chore(deps): lock file maintenance by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/2460](https://redirect.github.com/tj-actions/changed-files/pull/2460) **Full Changelog**: tj-actions/changed-files@v45...v45.0.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "* 0-3 * * 1" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/codegen-sh/codegen). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDAuMiIsInVwZGF0ZWRJblZlciI6IjM5LjIwMC4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# Motivation <!-- Why is this change necessary? --> # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [ ] I have added tests for my changes - [ ] I have updated the documentation or added new documentation as needed
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jupyterlab](https://redirect.github.com/jupyterlab/jupyterlab) ([changelog](https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.html)) | `==4.3.5` -> `==4.3.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jupyterlab/jupyterlab (jupyterlab)</summary> ### [`v4.3.6`](https://redirect.github.com/jupyterlab/jupyterlab/releases/tag/v4.3.6) [Compare Source](https://redirect.github.com/jupyterlab/jupyterlab/compare/v4.3.5...v4.3.6) ##### 4.3.6 ([Full Changelog](https://redirect.github.com/jupyterlab/jupyterlab/compare/v4.3.5...ef6df9b9234692d5449808bf6cd845562400ab93)) ##### Enhancements made - Remove spurious regex to slightly improve performance of streaming large outputs [#​17262](https://redirect.github.com/jupyterlab/jupyterlab/pull/17262) ([@​krassowski](https://redirect.github.com/krassowski)) ##### Bugs fixed - Fix cell output stream if previous chunk did not end in new line [#​17369](https://redirect.github.com/jupyterlab/jupyterlab/pull/17369) ([@​davidbrochart](https://redirect.github.com/davidbrochart)) - Updated enabling logic for run-all-below button on Notebook Panel [#​17298](https://redirect.github.com/jupyterlab/jupyterlab/pull/17298) ([@​rsaditya01](https://redirect.github.com/rsaditya01)) - Fix for issue preventing cell metadata removal [#​17194](https://redirect.github.com/jupyterlab/jupyterlab/pull/17194) ([@​itsmevichu](https://redirect.github.com/itsmevichu)) - Ensure search highlight is applied to Python builtin keywords [#​17160](https://redirect.github.com/jupyterlab/jupyterlab/pull/17160) ([@​hxrshxz](https://redirect.github.com/hxrshxz)) - Add missing aria labels in application shell [#​17192](https://redirect.github.com/jupyterlab/jupyterlab/pull/17192) ([@​Rishab87](https://redirect.github.com/Rishab87)) - Fixing dialog closing unexpectedly when typing in the textarea [#​17142](https://redirect.github.com/jupyterlab/jupyterlab/pull/17142) ([@​Rishab87](https://redirect.github.com/Rishab87)) ##### Maintenance and upkeep improvements - \[4.3.x] Update reference snapshots [#​17383](https://redirect.github.com/jupyterlab/jupyterlab/pull/17383) ([@​jtpio](https://redirect.github.com/jtpio)) - Bump `semver` and `tough-cookie` to non-vulnerable versions [#​17319](https://redirect.github.com/jupyterlab/jupyterlab/pull/17319) ([@​dlqqq](https://redirect.github.com/dlqqq)) - Bump vega from 5.24.0 to 5.26.0 [#​17295](https://redirect.github.com/jupyterlab/jupyterlab/pull/17295) ([@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot)) - Fix missing checks for author comment association for docs [#​17289](https://redirect.github.com/jupyterlab/jupyterlab/pull/17289) ([@​krassowski](https://redirect.github.com/krassowski)) ##### Documentation improvements - Clarify documentation on bot privileges for updating snapshots [#​17336](https://redirect.github.com/jupyterlab/jupyterlab/pull/17336) ([@​Princekumarofficial](https://redirect.github.com/Princekumarofficial)) ##### Contributors to this release ([GitHub contributors page for this release](https://redirect.github.com/jupyterlab/jupyterlab/graphs/contributors?from=2025-01-29\&to=2025-03-14\&type=c)) [@​afshin](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Aafshin+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​andrii-i](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Aandrii-i+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​bollwyvl](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Abollwyvl+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​Carreau](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3ACarreau+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​Darshan808](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3ADarshan808+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​dlqqq](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Adlqqq+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​echarles](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Aecharles+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​fcollonval](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Afcollonval+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​fleming79](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Afleming79+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​github-actions](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Agithub-actions+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​hxrshxz](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Ahxrshxz+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​ianthomas23](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Aianthomas23+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​JasonWeill](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3AJasonWeill+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​jtpio](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Ajtpio+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​jupyterlab-probot](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Ajupyterlab-probot+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​krassowski](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Akrassowski+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​lumberbot-app](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Alumberbot-app+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​martinRenou](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3AmartinRenou+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​meeseeksmachine](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Ameeseeksmachine+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​rpwagner](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Arpwagner+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​RRosio](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3ARRosio+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​trungleduc](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3Atrungleduc+updated%3A2025-01-29..2025-03-14\&type=Issues) | [@​Zsailer](https://redirect.github.com/search?q=repo%3Ajupyterlab%2Fjupyterlab+involves%3AZsailer+updated%3A2025-01-29..2025-03-14\&type=Issues) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "* 0-3 * * 1" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/codegen-sh/codegen). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM5LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Contributor
|
🎉 This PR is included in version 0.51.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Content
Testing
Please check the following before marking your PR as ready for review