Skip to content

Conversation

@lsagetlethias
Copy link
Collaborator

@lsagetlethias lsagetlethias commented May 20, 2025

  • add as="span | p | a | button" props to Tag
  • "p | a | button" are optional (because implicit)
  • only when as="span" we can add native span props

@lsagetlethias lsagetlethias requested a review from garronej May 20, 2025 13:21
@ddecrulle
Copy link
Collaborator

Thanks for your PR! Could you please stick to the existing format?
It makes it much easier to spot the changes and review the code efficiently.

@lsagetlethias
Copy link
Collaborator Author

Thanks for your PR! Could you please stick to the existing format? It makes it much easier to spot the changes and review the code efficiently.

I could, but the husky precommit hook will reformat as it is now

@lsagetlethias
Copy link
Collaborator Author

added a small comment hack to keep the indent as it was before

@garronej garronej merged commit 5147b06 into main May 20, 2025
6 checks passed
@garronej garronej deleted the feat/span-tag branch May 20, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants