#43: If the resource providing the archiver version does not exist, create

     'Created-by' manifest entries without version information.
     If the resource providing the archiver version exists but cannot be read,
     throw an 'AssertionError'.

Author: ChristianSchulte

src/main/java/org/codehaus/plexus/archiver/jar/JdkManifestFactory.java

@@ -49,26 +49,22 @@ public static java.util.jar.Manifest getDefaultManifest()
         return defaultManifest;
     }
 
-    private static String getArchiverVersion()
+    static String getArchiverVersion()
     {
-        String version = null;
-
         try
         {
             final Properties properties = PropertyUtils.loadProperties( JdkManifestFactory.class.getResourceAsStream(
                 "/META-INF/maven/org.codehaus.plexus/plexus-archiver/pom.properties" ) );
 
-            if ( properties != null )
-            {
-                version = properties.getProperty( "version" );
-            }
+            return properties != null
+                       ? properties.getProperty( "version" )
+                       : null;
+
         }
         catch ( final IOException e )
         {
-            version = null;
+            throw new AssertionError( e );
         }
-
-        return version;
     }
 
     public static void merge( java.util.jar.Manifest target, java.util.jar.Manifest other, boolean overwriteMain )

src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java

@@ -30,13 +30,11 @@
 import java.util.Hashtable;
 import java.util.Iterator;
 import java.util.Locale;
-import java.util.Properties;
 import java.util.StringTokenizer;
 import java.util.Vector;
 import java.util.jar.Attributes;
 
 import org.codehaus.plexus.archiver.ArchiverException;
-import org.codehaus.plexus.util.PropertyUtils;
 
 /**
  * Holds the data of a jar manifest.
@@ -740,7 +738,7 @@ public static Manifest getDefaultManifest()
 
         String createdBy = "Plexus Archiver";
 
-        final String plexusArchiverVersion = getArchiverVersion();
+        final String plexusArchiverVersion = JdkManifestFactory.getArchiverVersion();
 
         if ( plexusArchiverVersion != null )
         {
@@ -752,28 +750,6 @@ public static Manifest getDefaultManifest()
         return defaultManifest;
     }
 
-    private static String getArchiverVersion()
-    {
-        String version = null;
-
-        try
-        {
-            final Properties properties = PropertyUtils.loadProperties( JdkManifestFactory.class.getResourceAsStream(
-                "/META-INF/maven/org.codehaus.plexus/plexus-archiver/pom.properties" ) );
-
-            if ( properties != null )
-            {
-                version = properties.getProperty( "version" );
-            }
-        }
-        catch ( final IOException e )
-        {
-            version = null;
-        }
-
-        return version;
-    }
-
     /**
      * Construct an empty manifest
      */