Remove native chmod tool execution in tests
#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Runtime.getRuntime().exec( "chmod 440 " + ` causes security warnings because it concatenates arguments (there is a risk of argument injection). The argument does not come from untrusted source, but as we can use Java to change a file mode, it is better to remove the `chmod` invocation altogether. `chmod` was necessary before Java 7 as there was no support for changing file modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime.getRuntime().exec( "chmod 440 " +causessecurity warnings because it concatenates arguments
(there is a risk of argument injection).
The argument does not come from untrusted source,
but as we can use Java to change a file mode, it is
better to remove the
chmodinvocation altogether.chmodwas necessary before Java 7 as therewas no support for changing file modes.