Skip to content

Remove native chmod tool execution in tests #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2021
Merged

Remove native chmod tool execution in tests #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/test/java/org/codehaus/plexus/archiver/tar/TarFileAttributesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import org.codehaus.plexus.archiver.Archiver;
import org.codehaus.plexus.archiver.UnArchiver;
import org.codehaus.plexus.archiver.util.DefaultArchivedFileSet;
import org.codehaus.plexus.components.io.attributes.AttributeUtils;
import org.codehaus.plexus.components.io.attributes.PlexusIoResourceAttributeUtils;
import org.codehaus.plexus.components.io.attributes.PlexusIoResourceAttributes;
import org.codehaus.plexus.util.FileUtils;
Expand Down Expand Up @@ -87,8 +88,7 @@ public void testUseAttributesFromTarArchiveInputInTarArchiverOutput()
writer.write( "This is a test file." );
}

int result = Runtime.getRuntime().exec( "chmod 440 " + tempFile.getAbsolutePath() ).waitFor();
assertEquals( 0, result );
AttributeUtils.chmod(tempFile, 0440);

TarArchiver tarArchiver = getPosixCompliantTarArchiver();

Expand Down Expand Up @@ -153,9 +153,7 @@ public void testUseDetectedFileAttributes()
writer.write( "This is a test file." );
}

int result = Runtime.getRuntime().exec( "chmod 440 " + tempFile.getAbsolutePath() ).waitFor();

assertEquals( 0, result );
AttributeUtils.chmod(tempFile, 0440);

PlexusIoResourceAttributes fileAttributes = PlexusIoResourceAttributeUtils.getFileAttributes( tempFile );

Expand Down Expand Up @@ -214,8 +212,7 @@ public void testOverrideDetectedFileAttributes()
writer.write( "This is a test file." );
}

int result = Runtime.getRuntime().exec( "chmod 440 " + tempFile.getAbsolutePath() ).waitFor();
assertEquals( 0, result );
AttributeUtils.chmod(tempFile, 0440);

TarArchiver tarArchiver = getPosixCompliantTarArchiver();

Expand Down Expand Up @@ -272,8 +269,7 @@ public void testOverrideDetectedFileAttributesUsingFileMode()
writer.write( "This is a test file." );
}

int result = Runtime.getRuntime().exec( "chmod 440 " + tempFile.getAbsolutePath() ).waitFor();
assertEquals( 0, result );
AttributeUtils.chmod(tempFile, 0440);

TarArchiver tarArchiver = getPosixCompliantTarArchiver();

Expand Down