Address review feedback: shorter method names, package-private constructor, copyright removal, create(String message)

Co-authored-by: laeubi <[email protected]>

Author: Copilot

README.md

@@ -52,18 +52,16 @@ private Messages messages;
 
 public void execute() {
     // Create an error message
-    messages.buildError(Paths.get("/path/to/file.java"))
+    messages.error(Paths.get("/path/to/file.java"))
         .line(42)
         .column(10)
-        .message("Syntax error")
         .cause(exception)
-        .create();
+        .create("Syntax error");
 
     // Create a warning message
-    messages.buildWarning(Paths.get("/path/to/file.java"))
+    messages.warning(Paths.get("/path/to/file.java"))
         .line(15)
-        .message("Deprecated method used")
-        .create();
+        .create("Deprecated method used");
 
     // Clear messages for a specific file
     messages.clear(Paths.get("/path/to/file.java"));

src/main/java/org/codehaus/plexus/build/BuildContext.java

@@ -209,6 +209,7 @@ public interface BuildContext {
      * @param cause A Throwable object associated with the message. Can be null.
      * @since 0.0.7
      * @param message a {@link java.lang.String} object.
+     * @deprecated Use {@link org.codehaus.plexus.build.messages.Messages} API instead
      */
     void addMessage(File file, int line, int column, String message, int severity, Throwable cause);
 
@@ -218,6 +219,7 @@ public interface BuildContext {
      *
      * @since 0.0.7
      * @param file a {@link java.io.File} object.
+     * @deprecated Use {@link org.codehaus.plexus.build.messages.Messages#clear(java.nio.file.Path)} instead
      */
     void removeMessages(File file);
 

src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java

@@ -1,6 +1,4 @@
 /*
-Copyright (c) 2008 Sonatype, Inc. All rights reserved.
-
 This program is licensed to you under the Apache License Version 2.0,
 and you may not use this file except in compliance with the Apache License Version 2.0.
 You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0.
@@ -62,17 +60,17 @@ public void clear(Path path) {
     }
 
     @Override
-    public MessageBuilder buildError(Path path) {
+    public MessageBuilder error(Path path) {
         return build(MessageType.ERROR, path);
     }
 
     @Override
-    public MessageBuilder buildWarning(Path path) {
+    public MessageBuilder warning(Path path) {
         return build(MessageType.WARNING, path);
     }
 
     @Override
-    public MessageBuilder buildInfo(Path path) {
+    public MessageBuilder info(Path path) {
         return build(MessageType.INFO, path);
     }
 
@@ -167,10 +165,8 @@ private int mapTypeToSeverity(MessageType type) {
                 return BuildContext.SEVERITY_WARNING;
             case INFO:
             default:
-                // There's no INFO severity in BuildContext (only WARNING and ERROR),
-                // so we map INFO messages to WARNING to ensure they are still visible in the IDE.
-                // Custom implementations may provide different mappings.
-                return BuildContext.SEVERITY_WARNING;
+                // BuildContext supports 0 as an info severity level (undocumented)
+                return 0;
         }
     }
 }

src/main/java/org/codehaus/plexus/build/messages/Message.java

@@ -1,6 +1,4 @@
 /*
-Copyright (c) 2008 Sonatype, Inc. All rights reserved.
-
 This program is licensed to you under the Apache License Version 2.0,
 and you may not use this file except in compliance with the Apache License Version 2.0.
 You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0.
@@ -36,7 +34,7 @@ public class Message {
      * @param message the message text
      * @param cause the exception cause, can be null
      */
-    public Message(MessageType type, Path path, int line, int column, String message, Throwable cause) {
+    Message(MessageType type, Path path, int line, int column, String message, Throwable cause) {
         this.type = type;
         this.path = path;
         this.line = line;

src/main/java/org/codehaus/plexus/build/messages/MessageBuilder.java

@@ -1,6 +1,4 @@
 /*
-Copyright (c) 2008 Sonatype, Inc. All rights reserved.
-
 This program is licensed to you under the Apache License Version 2.0,
 and you may not use this file except in compliance with the Apache License Version 2.0.
 You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0.
@@ -30,7 +28,6 @@ public class MessageBuilder {
 
     private int line = 0;
     private int column = 0;
-    private String message;
     private Throwable cause;
 
     /**
@@ -72,17 +69,6 @@ public MessageBuilder column(int column) {
         return this;
     }
 
-    /**
-     * Sets the message text.
-     *
-     * @param message the message text
-     * @return this builder for method chaining
-     */
-    public MessageBuilder message(String message) {
-        this.message = message;
-        return this;
-    }
-
     /**
      * Sets the exception cause for the message.
      *
@@ -97,8 +83,13 @@ public MessageBuilder cause(Throwable cause) {
     /**
      * Creates the message object with all collected parameters and informs the consumer.
      * This method finalizes the builder and creates the message.
+     *
+     * @param message the message text (must not be null or blank)
      */
-    public void create() {
+    public void create(String message) {
+        if (message == null || message.trim().isEmpty()) {
+            throw new IllegalArgumentException("Message text must not be null or blank");
+        }
         Message msg = new Message(type, path, line, column, message, cause);
         consumer.accept(msg);
     }

src/main/java/org/codehaus/plexus/build/messages/MessageType.java

@@ -1,6 +1,4 @@
 /*
-Copyright (c) 2008 Sonatype, Inc. All rights reserved.
-
 This program is licensed to you under the Apache License Version 2.0,
 and you may not use this file except in compliance with the Apache License Version 2.0.
 You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0.

src/main/java/org/codehaus/plexus/build/messages/Messages.java

@@ -1,6 +1,4 @@
 /*
-Copyright (c) 2008 Sonatype, Inc. All rights reserved.
-
 This program is licensed to you under the Apache License Version 2.0,
 and you may not use this file except in compliance with the Apache License Version 2.0.
 You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0.
@@ -26,11 +24,10 @@
  * Example usage:
  * </p>
  * <pre>
- * messages.buildError(Paths.get("/path/to/file.java"))
+ * messages.error(Paths.get("/path/to/file.java"))
  *     .line(42)
  *     .column(10)
- *     .message("Syntax error")
- *     .create();
+ *     .create("Syntax error");
  * </pre>
  */
 public interface Messages {
@@ -54,23 +51,23 @@ public interface Messages {
      * @param path the file path for which the error message should be created
      * @return a MessageBuilder for constructing the error message
      */
-    MessageBuilder buildError(Path path);
+    MessageBuilder error(Path path);
 
     /**
      * Creates a builder for a warning message.
      *
      * @param path the file path for which the warning message should be created
      * @return a MessageBuilder for constructing the warning message
      */
-    MessageBuilder buildWarning(Path path);
+    MessageBuilder warning(Path path);
 
     /**
      * Creates a builder for an informational message.
      *
      * @param path the file path for which the info message should be created
      * @return a MessageBuilder for constructing the info message
      */
-    MessageBuilder buildInfo(Path path);
+    MessageBuilder info(Path path);
 
     /**
      * Creates a builder for a message of a specific type.