Skip to content

Add module-info.java for JPMS support using multi-release JAR #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2025
Merged

Add module-info.java for JPMS support using multi-release JAR #90

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b7b3c3
Initial plan
Copilot Nov 1, 2025
f5f1f07
Add module-info.java and configure multi-release compilation
Copilot Nov 1, 2025
a5f41f8
Explicitly set release=8 in base-compile execution for clarity
Copilot Nov 1, 2025
793c207
Move module compilation to java9+ profile activated on JDK 9+
Copilot Nov 1, 2025
37ac139
Move module-info.java to src/main/java9 for multi-release JAR
Copilot Nov 1, 2025
298285e
Remove unnecessary exports from module-info.java
slachiewicz Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,48 @@
</plugins>
</build>

<profiles>
<profile>
<id>java9+</id>
<activation>
<jdk>[9,)</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<executions>
<execution>
<id>compile-java9</id>
<goals>
<goal>compile</goal>
</goals>
<phase>compile</phase>
<configuration>
<release>9</release>
<compileSourceRoots>
<compileSourceRoot>${project.basedir}/src/main/java9</compileSourceRoot>
</compileSourceRoots>
<multiReleaseOutput>true</multiReleaseOutput>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestEntries>
<Multi-Release>true</Multi-Release>
</manifestEntries>
</archive>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>
9 changes: 9 additions & 0 deletions src/main/java9/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
module org.codehaus.plexus.interpolation {
exports org.codehaus.plexus.interpolation;
exports org.codehaus.plexus.interpolation.fixed;
exports org.codehaus.plexus.interpolation.multi;
exports org.codehaus.plexus.interpolation.object;
exports org.codehaus.plexus.interpolation.os;
exports org.codehaus.plexus.interpolation.reflection;
exports org.codehaus.plexus.interpolation.util;
Copy link
Member

@slawekjaranowski slawekjaranowski Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfscholte @slachiewicz do we need export all packages ....?

eg org.codehaus.plexus.interpolation.os look like internal one?

Copy link
Member

@rfscholte rfscholte Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my hope was only org.codehaus.plexus.interpolation;

however, a quick scan through the Maven codebase:
DefaultToolchainsBuilderTest uses org.codehaus.plexus.interpolation.os.OperatingSystemUtils
PathTranslatingPostProcessor uses org.codehaus.plexus.interpolation.util.ValueSourceUtils

as long as Maven is not using the modulepath that's not an issue.

I would probably go for only org.codehaus.plexus.interpolation and investigate if there are requests for opening more packages

}