refactor: avoid repetitive call pg_last_error()

samsonasik · samsonasik · commit 0bb7119ea582 · 2024-12-27T09:34:04.000+07:00
diff --git a/system/Database/Postgre/Connection.php b/system/Database/Postgre/Connection.php
@@ -461,9 +461,10 @@ protected function _enableForeignKeyChecks()
      */
     public function error(): array
     {
+        $lastError = pg_last_error($this->connID);
         return [
             'code'    => '',
-            'message' => ! in_array(pg_last_error($this->connID), ['', '0'], true) ? pg_last_error($this->connID) : '',
+            'message' => ! in_array($lastError, ['', '0'], true) ? $lastError : '',
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -461,9 +461,10 @@ protected function _enableForeignKeyChecks()`
`461`	`461`	`*/`
`462`	`462`	`public function error(): array`
`463`	`463`	`{`
	`464`	`+ $lastError = pg_last_error($this->connID);`
`464`	`465`	`return [`
`465`	`466`	`'code' => '',`
`466`		`- 'message' => ! in_array(pg_last_error($this->connID), ['', '0'], true) ? pg_last_error($this->connID) : '',`
	`467`	`+ 'message' => ! in_array($lastError, ['', '0'], true) ? $lastError : '',`
`467`	`468`	`];`
`468`	`469`	`}`
`469`	`470`