refactor: use empty string check on guessExtension

samsonasik · samsonasik · commit da47f21d629c · 2024-12-27T10:38:10.000+07:00
diff --git a/system/HTTP/Files/UploadedFile.php b/system/HTTP/Files/UploadedFile.php
@@ -302,7 +302,8 @@ public function getTempName(): string
      */
     public function getExtension(): string
     {
-        return ! in_array($this->guessExtension(), ['', '0'], true) ? $this->guessExtension() : $this->getClientExtension();
+        $guessExtension = $this->guessExtension();
+        return $guessExtension !== '' ? $guessExtension : $this->getClientExtension();
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,8 @@ public function getTempName(): string`
`302`	`302`	`*/`
`303`	`303`	`public function getExtension(): string`
`304`	`304`	`{`
`305`		`- return ! in_array($this->guessExtension(), ['', '0'], true) ? $this->guessExtension() : $this->getClientExtension();`
	`305`	`+ $guessExtension = $this->guessExtension();`
	`306`	`+ return $guessExtension !== '' ? $guessExtension : $this->getClientExtension();`
`306`	`307`	`}`
`307`	`308`
`308`	`309`	`/**`