Skip to content

Conversation

neznaika0
Copy link
Contributor

Description
I don't understand why this is not detected on github, but there is a bug in the local environment.
Perhaps the cache is interfering here
Replace to <false></false>:

1) CodeIgniter\Test\FeatureTestTraitTest::testSetupRequestBodyWithXml
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 '<?xml version="1.0"?>
-<response><true>1</true><false/><int>2</int><null/><float>1.23</float><string>foo</string></response>
+<response><true>1</true><false></false><int>2</int><null></null><float>1.23</float><string>foo</string></response>
 '

@kenjis kenjis added the testing Pull requests that changes tests only label Sep 15, 2024
@kenjis
Copy link
Member

kenjis commented Sep 15, 2024

@kenjis
Copy link
Member

kenjis commented Sep 15, 2024

<false/> is correct.

@kenjis kenjis closed this Sep 15, 2024
@kenjis
Copy link
Member

kenjis commented Sep 15, 2024

Your library linked to PHP (libxml) is old?

@neznaika0
Copy link
Contributor Author

Maybe. I am using Debian Testing, php 8.3.9
My tests are not running on the local PC. I wanted to correct it. Apparently, you will never achieve the perfect environment (without docker)

@neznaika0 neznaika0 deleted the fix-xml-response-test branch September 15, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants