fix: curl request crashes with params that give an int once hexed. #9198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
approved these changes
Sep 23, 2024
ddevsr
added
the
bug
ddevsr
approved these changes
Sep 23, 2024
paulbalandan
approved these changes
Oct 1, 2024
|
@ping-yee rebase commit. Why is it taking so long to merge? |
|
It seems there is phpstan notice https://github.com/codeigniter4/CodeIgniter4/actions/runs/10974631732/job/30473366987?pr=9198 |
|
I cannot force push to pingyee's fork to update this PR. Anyway, I rebased locally and checked that the phpstan notice goes away. I'll squash and merge this to be on top of develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9193
Checklist: