Skip to content

refactor: enable rector code quality level 15 #9243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

refactor: enable rector code quality level 15 #9243

merged 1 commit into from
Oct 28, 2024

Conversation

@samsonasik
Copy link
Member

Description

Applied SimplifyUselessVariableRector to removes useless variable assigns

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @paulbalandan for the review, let's merge ;)

@samsonasik samsonasik merged commit 8522a37 into codeigniter4:develop Oct 28, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-apply-code-quality-level-15 branch October 28, 2024 15:46
@kenjis kenjis added the refactor Pull requests that refactor code label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis Awaiting requested review from kenjis

@MGatner MGatner Awaiting requested review from MGatner

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @paulbalandan @kenjis