Skip to content

Conversation

@neznaika0
Copy link
Contributor

Description
Closes #9204, #9211
Before that, the method could not get a value if the POST, GET... data is stored as a list.
This affected FeatureTestTrait

I think there is a potential error in fetchGlobal() - it does not understand the numeric keys $_GET[0]['one'] = 1

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@neznaika0 neznaika0 changed the title Fix: fetchGlobal() with numeric key fix: fetchGlobal() with numeric key Nov 3, 2024
@neznaika0 neznaika0 force-pushed the fix-fetch-global-request branch from 3051bde to 86891de Compare November 3, 2024 18:35
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please, clean up the changelog a bit.

@neznaika0 neznaika0 force-pushed the fix-fetch-global-request branch from 86891de to 02a049f Compare November 4, 2024 07:06
@neznaika0 neznaika0 requested a review from michalsn November 4, 2024 07:48
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 5, 2024
@neznaika0 neznaika0 force-pushed the fix-fetch-global-request branch from 8752b1d to b0d7541 Compare November 5, 2024 14:10
@neznaika0 neznaika0 force-pushed the fix-fetch-global-request branch from b0d7541 to 2642a9b Compare November 9, 2024 20:32
@samsonasik
Copy link
Member

Thank you @neznaika0

@samsonasik samsonasik merged commit fcf37d6 into codeigniter4:develop Nov 13, 2024
42 checks passed
@neznaika0 neznaika0 deleted the fix-fetch-global-request branch December 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants