Skip to content

Conversation

@samsonasik
Copy link
Member

Description

enable FlipTypeControlToUseExclusiveTypeRector to flip type control from null compare to use exclusive instanceof object for more verbose check.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @paulbalandan for the review, let's merge ;)

@samsonasik samsonasik merged commit 65872e5 into codeigniter4:develop Nov 5, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-enable-flip-type-control branch November 5, 2024 06:40
@kenjis kenjis added the refactor Pull requests that refactor code label Nov 5, 2024
@neznaika0
Copy link
Contributor

Does the rule only apply to available classes? There is just a question when using helpers - config('App') service('routes') - they can accept not only built-in classes, but also custom

@samsonasik
Copy link
Member Author

It check based on native type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants