Skip to content

Conversation

@michalsn
Copy link
Member

@michalsn michalsn commented Dec 7, 2024

Description
This PR fixes a bug that caused the Model::getIdValue() to not correctly recognize the primary key in the Entity object if a data mapping for the primary key was used.

Fixes: #9306

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 9, 2024
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Dec 11, 2024
@michalsn michalsn merged commit 539436f into codeigniter4:develop Dec 11, 2024
42 checks passed
@michalsn
Copy link
Member Author

Thanks everyone!

@michalsn michalsn deleted the fix/entity-mapped-primaryKey branch December 31, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Mapping Entity's primary key breaks Models save()

3 participants