Skip to content

refactor: rename controller to Controller #9314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

refactor: rename controller to Controller #9314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions phpstan-baseline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16573,12 +16573,6 @@
'count' => 2,
'path' => __DIR__ . '/tests/system/Router/RouteCollectionTest.php',
];
$ignoreErrors[] = [
// identifier: class.nameCase
'message' => '#^Class CodeIgniter\\\\Controller referenced with incorrect case\\: CodeIgniter\\\\controller\\.$#',
'count' => 2,
'path' => __DIR__ . '/tests/system/Router/RouteCollectionTest.php',
];
$ignoreErrors[] = [
// identifier: missingType.return
'message' => '#^Method CodeIgniter\\\\Router\\\\RouteCollectionTest\\:\\:getCollector\\(\\) has no return type specified\\.$#',
Expand Down
6 changes: 3 additions & 3 deletions tests/system/Router/RouteCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace CodeIgniter\Router;

use App\Controllers\Product;
use CodeIgniter\controller;
use CodeIgniter\Controller;
use CodeIgniter\Exceptions\PageNotFoundException;
use CodeIgniter\HTTP\Method;
use CodeIgniter\Test\CIUnitTestCase;
Expand Down Expand Up @@ -243,10 +243,10 @@ public function testAddRecognizesCustomNamespaces(): void
$routes = $this->getCollector();
$routes->setDefaultNamespace('\CodeIgniter');

$routes->add('home', 'controller');
$routes->add('home', 'Controller');

$expects = [
'home' => '\\' . controller::class,
'home' => '\\' . Controller::class,
];

$routes = $routes->getRoutes();
Expand Down
Loading