Skip to content

refactor: follow up implicit variable array #9319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

refactor: follow up implicit variable array #9319

merged 1 commit into from
Dec 12, 2024

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Dec 12, 2024

Description
Follow-up style codeigniter4/codeigniter4#9316.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the refactor Pull requests that refactor code label Dec 12, 2024
@ddevsr ddevsr marked this pull request as ready for review December 12, 2024 11:07
@ddevsr ddevsr requested a review from paulbalandan December 12, 2024 11:12
@paulbalandan paulbalandan changed the title refactor: followup implicit variable array refactor: follow up implicit variable array Dec 12, 2024
@paulbalandan paulbalandan merged commit 0f5de27 into codeigniter4:develop Dec 12, 2024
41 checks passed
@ddevsr ddevsr deleted the refactor-style branch December 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@neznaika0 neznaika0 neznaika0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr @neznaika0 @paulbalandan