Skip to content

refactor: fix Forge::processIndexes() for empty $this->fields #9330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

refactor: fix Forge::processIndexes() for empty $this->fields #9330

merged 1 commit into from
Dec 19, 2024

Conversation

@paulbalandan
Copy link
Member

Description
Latest PHPStan changed the error message, so fixing this now.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Dec 19, 2024
@paulbalandan paulbalandan merged commit f48aa6f into codeigniter4:develop Dec 19, 2024
41 checks passed
@paulbalandan paulbalandan deleted the forge-fields branch December 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@ddevsr ddevsr ddevsr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @michalsn @ddevsr