4.5.6 Ready code #9345

paulbalandan · 2024-12-28T17:32:14Z

No description provided.

docs: add changelog and upgrade for v4.5.6

docs: improve url_helper.rst

docs: update RELEASE.md

The scheme is missing, so it is not a valid URL.

docs: improve "Migration File Names"

Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@1.2.4...1.2.5) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>

…/rector-1.2.5 chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5

refactor: enable TypedPropertyFromAssignsRector

refactor: enable ClosureReturnTypeRector

docs: broken link htmx ajax-header

See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265

fix: auto_link() converts invalid strings like `://codeigniter.com`

docs: fix Project Files changes in upgrade_455.rst

refactor: fix `method.nameCase` errors

…oller refactor: rename `controller` to `Controller`

refactor: fix implicit array creation

* fix: check if defined WRITEPATH exists * cs fix * Update system/Boot.php Co-authored-by: Pooya Parsa <[email protected]> * cs fix --------- Co-authored-by: Pooya Parsa <[email protected]>

…seRule

chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule

* refactor: split phpstan-baseline into smaller files * Checkout base branch to resolve codeigniter4/framework * Fix rector changes

* Update FileHandler.php * Update BaseConnection.php * Update Connection.php * Update filesystem_helper.php * Update Security.php * Update SecurityInterface.php

* Update 006.php * Update 008.php * Update 046.php

)

…er (#9327)

* fix prepare statement sqlite * fix prepare statement postgre * fix prepare statement sqlsrv * fix prepare statement oci8 * tests * abstract isBinary() method * fix prepare statement mysqli * fix prepare statement oci8 * sqlsrv blob support * fix tests * add changelog * fix rector * make sqlsrv happy * make oci8 happy - hopefully * add a note about options for prepared statement * ignore PreparedQueryTest.php file * apply code suggestion for oci8

refactor: fix warning on new static usage

* refactor: Fix `phpstan` boolean errors * fix: Check predis response * refactor: Improve comparison with an empty string * dev: Update phpstan-baseline * fix: Revert comparison with null

* refactor: enable instanceof and strictBooleans rector set * refactor: bump to rector 2.0.4 * refactor: clean condition check * refactor: revert ThirdParty change * refactor: re-run phpstan baseline * refactor: fix never empty array on Image * refactor: avoid repetitive call pg_last_error() * refactor: pg_last_error() always returns string * refactor: use return empty string on pg_last_error() got empty "0" * refactor: various compare !== 1 on preg_match() * refactor: use falsy check on getenv() * refactor: more !== 1 compare on preg_match() * refactor: use empty string check on guessExtension * refactor: run cs fix * refactor: more !== 1 compare on preg_match() * use direct result of pg_last_error() * refactor: use str_contains() over strpos on Forge * refactor: fix unused variable * refactor: check empty string on ResponseTrait * refactor: more preg_match() and empty string only check * refactor: compare to 0 on preg_match_all() * refactor: re-run rector * refactor: preg_match_all() likely less to return false

paulbalandan · 2024-12-28T17:49:27Z

I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.

Fixed in #9346

kenjis and others added 30 commits September 6, 2024 13:53

docs: fix param types

3dfd4bc

docs: decorate text

2ef57ab

docs: add changelog and upgrade for v4.5.6

b5b2e57

docs: add note

ee9ae5f

docs: move item

2492078

docs: move section

cb4ba98

docs: use GitHub markdown note format

d7bedff

Merge pull request #9175 from kenjis/docs-changelog-4.5.6

ce7f591

docs: add changelog and upgrade for v4.5.6

Merge pull request #9171 from kenjis/docs-url_helper.rst

268156c

docs: improve url_helper.rst

Merge pull request #9176 from kenjis/update-RELEASE.md

0a6b39d

docs: update RELEASE.md

docs: improve description for Migration File Names

22cf15e

docs: add link to section

7113792

docs: fix typo

e53c32c

fix: auto_link() converts invalid string like "://codeigniter.com"

791fe2f

The scheme is missing, so it is not a valid URL.

refactor: break long lines

94fe31f

Merge pull request #9179 from kenjis/improve-migration-file-names

647f4e7

docs: improve "Migration File Names"

Fix phpstan

0a9835b

Merge pull request #9183 from codeigniter4/dependabot/composer/rector…

b678930

…/rector-1.2.5 chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5

refactor: enable TypedPropertyFromAssignsRector

45a002f

docs: broken link htmx ajax-header

fe65154

Merge pull request #9184 from samsonasik/refactor-typed-property

092d85b

refactor: enable TypedPropertyFromAssignsRector

refactor: enable ClosureReturnTypeRector

3f29f28

Fix cs

8ecbf0d

Merge pull request #9187 from samsonasik/refactor-enable-closure-return

1528d3d

refactor: enable ClosureReturnTypeRector

Merge pull request #9185 from ddevsr/broken-link-htmx-ajax

36f9c2f

docs: broken link htmx ajax-header

docs: fix Project Files changes

7d2d81c

See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265

Merge pull request #9180 from kenjis/fix-auto_link-bug

d49d700

fix: auto_link() converts invalid strings like `://codeigniter.com`

chore: update psr/log to 3.0.2

d6850d4

Merge pull request #9188 from kenjis/fix-upgrade_455.rst

bd3ee0f

docs: fix Project Files changes in upgrade_455.rst

samsonasik and others added 24 commits December 11, 2024 23:48

Merge pull request #9315 from paulbalandan/method-namecase

f5200b5

refactor: fix `method.nameCase` errors

Merge pull request #9314 from paulbalandan/rename-controller-to-Contr…

0b0126c

…oller refactor: rename `controller` to `Controller`

refactor: fix implicit array creation

c06d928

Merge pull request #9316 from paulbalandan/implicit-array-creation

e9bb603

refactor: fix implicit array creation

fix: check if defined WRITEPATH exists (#9317)

9bc61b3

* fix: check if defined WRITEPATH exists * cs fix * Update system/Boot.php Co-authored-by: Pooya Parsa <[email protected]> * cs fix --------- Co-authored-by: Pooya Parsa <[email protected]>

refactor: followup style variable array (#9319)

0f5de27

chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…

94e57df

…seRule

chore: fix ci run

6644b79

Merge pull request #9321 from samsonasik/chore-prepare-phpstan-2

f0536a1

chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule

refactor: split phpstan-baseline into smaller files (#9299)

242745c

* refactor: split phpstan-baseline into smaller files * Checkout base branch to resolve codeigniter4/framework * Fix rector changes

refactor: upgrade to use phpstan 2 and rector 2 (#9322)

61881bd

docs: phpdoc incorrect explanation regarding variable naming (#9326)

17f7a9d

* Update FileHandler.php * Update BaseConnection.php * Update Connection.php * Update filesystem_helper.php * Update Security.php * Update SecurityInterface.php

docs: variable naming adjustments (#9324)

cc2dcee

* Update 006.php * Update 008.php * Update 046.php

refactor: fix Forge::processIndexes() for empty $this->fields (#9330

f48aa6f

)

fix: Remove DB files after tests (#9192)

ab5536f

refactor: Reflection*::setAccessible() is now no-op in PHP 8.1 (#9331)

8fa419f

refactor: add @throws RedirectException in Controller::initControll…

cc1b8f2

…er (#9327)

refactor: fix warning on new static usage

2114577

Merge pull request #9342 from paulbalandan/new-static

e363f47

refactor: fix warning on new static usage

refactor: fix used void return type (#9341)

19ad2b9

refactor: fix phpstan only boolean allowed (#9302)

8cff099

* refactor: Fix `phpstan` boolean errors * fix: Check predis response * refactor: Improve comparison with an empty string * dev: Update phpstan-baseline * fix: Revert comparison with null

Prep for 4.5.6 release (#9344)

6785d8f

samsonasik approved these changes Dec 28, 2024

View reviewed changes

This was referenced Dec 28, 2024

chore: add branch-alias for master branch #9346

Merged

Prep for 4.5.6 release #9344

Merged

chore: add branch-alias for master branch (#9346)

ebb5bd7

paulbalandan merged commit 51cdd7d into master Dec 28, 2024
43 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

4.5.6 Ready code #9345

4.5.6 Ready code #9345

Uh oh!

paulbalandan commented Dec 28, 2024

Uh oh!

paulbalandan commented Dec 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

4.5.6 Ready code #9345

4.5.6 Ready code #9345

Uh oh!

Conversation

paulbalandan commented Dec 28, 2024

Uh oh!

paulbalandan commented Dec 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

paulbalandan commented Dec 28, 2024 •

edited

Loading