Skip to content

refactor: Fix phpstan if.condNotBoolean #9368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

refactor: Fix phpstan if.condNotBoolean #9368

merged 1 commit into from
Jan 4, 2025
+1 −10

Conversation

@neznaika0
Copy link
Contributor

Description
This is a rare case, but there are no tests for wrong $options values ("", null, [] ...). Leaving it?

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine as CLI::write will check it anyway, if I'm not mistaken.

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jan 4, 2025
@paulbalandan paulbalandan merged commit db12ec3 into codeigniter4:develop Jan 4, 2025
41 checks passed
@neznaika0 neznaika0 deleted the refactor/phpstan-cond-not-bool branch January 4, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neznaika0 @michalsn @paulbalandan