Skip to content

Conversation

@neznaika0
Copy link
Contributor

@neznaika0 neznaika0 commented Jan 12, 2025

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@neznaika0
Copy link
Contributor Author

It is possible to specify a local version vendor/phpunit/phpunit/phpunit.xsd for better compatibility.

@paulbalandan
Copy link
Member

It is possible to specify a local version vendor/phpunit/phpunit/phpunit.xsd for better compatibility.

Yes, this is what I'm doing in my libraries. It ensures you are using the latest schema of the phpunit version you are running.

@neznaika0
Copy link
Contributor Author

neznaika0 commented Jan 13, 2025

@paulbalandan sorry, offtop. Delete it after.

Who has access to the mail [email protected] ? I have sent an email, but there is no response yet. Should I open a security PR?

EDIT: oh, send to [email protected]

@paulbalandan
Copy link
Member

@paulbalandan sorry, offtop. Delete it after.

Who has access to the mail [email protected] ? I have sent an email, but there is no response yet. Should I open a security PR?

Thanks. I've asked in slack. I'll update once I got alternate email.

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Jan 13, 2025
@paulbalandan
Copy link
Member

EDIT: oh, send to [email protected]

Yes, I've confirmed this. You can send your report there.

@paulbalandan paulbalandan merged commit d47a258 into codeigniter4:develop Jan 14, 2025
39 checks passed
@neznaika0 neznaika0 deleted the chore/phpunit-config branch January 14, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants