Skip to content

refactor: use assertNotInstanceOf over assertNull on nullable object return and flip actual/expect on constant check #9440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

refactor: use assertNotInstanceOf over assertNull on nullable object return and flip actual/expect on constant check #9440

merged 1 commit into from
Feb 4, 2025

Conversation

@samsonasik
Copy link
Member

Description

Run rector latest dev-main.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
refactor: use assertNotInstanceOf over assertNull on nullable object …
3eae990 
…return and flip actual/expect on constant check
@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

@paulbalandan thank you for the review, let's merge 👍

@samsonasik samsonasik merged commit e89ef62 into codeigniter4:develop Feb 4, 2025
47 checks passed
@samsonasik samsonasik deleted the refactor-assert-not branch February 4, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis Awaiting requested review from kenjis

@michalsn michalsn Awaiting requested review from michalsn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @paulbalandan