Skip to content

refactor: get upper first protocol only one call in Email #9449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

refactor: get upper first protocol only one call in Email #9449

merged 1 commit into from
Feb 12, 2025

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Feb 12, 2025

Description
Make one call.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the refactor Pull requests that refactor code label Feb 12, 2025
@samsonasik samsonasik merged commit 57a8859 into codeigniter4:develop Feb 12, 2025
48 checks passed
@samsonasik
Copy link
Member

Thank you @ddevsr

@ddevsr ddevsr deleted the patch-3 branch February 13, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddevsr @samsonasik