-
Couldn't load subscription status.
- Fork 2k
feat: add email/smtp plain auth method #9462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add email/smtp plain auth method #9462
Conversation
|
Hi there, ip-qi! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
1e680cb to
cfd2a60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this new option to the app\Config\Email.php file too.
We also need a changelog entry - the file will be available after merging #9464, so you will have to rebase.
a41e011 to
23b58b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates.
The changelog is now merged, so you can rebase and add an entry there (https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/changelogs/v4.7.0.rst), under the section: "Enhancements -> Libraries". You can check previous changelogs to see what convention we use.
2e48e51 to
beb8700
Compare
7d43afb to
27fc469
Compare
…ction return types -comment: add depreceation comment for failedSMTPLogin email error message -refactor: improve authorization validation flow and email error response messages -added $SMTPAuthMethod in Config\Email file with default value of login
27fc469 to
f3b64ed
Compare
apply suggestion for declaring string type of $SMTPAuthMethod Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Apply Suggestion for description of SMTPAuthMethod Co-authored-by: Michal Sniatala <[email protected]>
Apply suggestions for changelog Co-authored-by: Michal Sniatala <[email protected]>
|
@ip-qi Thank you and congratulations on your first contribution to the project! |
@michalsn You are most welcome! I really appreciate the help, collaboration, and direction from both you and @paulbalandan. |
$SMTPAuthMethod = 'LOGIN' <- which is by default set to LOGIN to avoid breaking existing email setups.
This can be overriden within Config\Email to utilize 'PLAIN' AUTH method
NOTE: 'LOGIN' method could not be tested currently from my part so if possible someone test it please, i have manually tested 'PLAIN' authentication method and it is working as expected.
Explain what you have changed, and why.
Checklist: