refactor: OCI8 limit() method
#9472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Mar 1, 2025
| * | ||
| * @var bool | ||
| */ | ||
| protected $limitUsed = false; |
There was a problem hiding this comment.
since it not exists on parent, this need to be kept, with mark @deprecated for patch release.
There was a problem hiding this comment.
I thought about it, but I realized it never had any use. It was simply a copy-paste from CI3 without the full implementation (in the Result::getFieldCount()), which makes it non-usable. It was a "dead" code from the beginning.
But I'm happy to make changes if more people share your view.
paulbalandan
approved these changes
Mar 4, 2025
|
Okay, I'm merging this. Thank you, @samsonasik and @paulbalandan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
limit()method in the OCI8 driver by removing legacy code that was only required for OCI8 versions below12.1, which are no longer supported by CodeIgniter.Reference: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/intro/requirements.rst?plain=1#L69
Closes: #9469
Checklist: