Skip to content

Conversation

@mavelo-llc
Copy link

@mavelo-llc mavelo-llc commented Mar 10, 2025

Description
form_dropdown_timezone() supports all parameters of form_dropdown() and timezone-specific parameters.
timezone_select() in date_helper.php is too limited. Cannot specify field name or extra attributes.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Add form_fropdown_timezone() that supports all form_fropdown() parameters. 

timezone_select() in date_helper.php is too limited. Cannot specify field name or extra attributes limiting

for backwards compatibility, maybe make timezone_select an alias/pass-through 🤷‍♂️
@mergeable
Copy link

mergeable bot commented Mar 10, 2025

Hi there, mavelo-llc! 👋

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work
on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sincerely, the mergeable bot 🤖

@ddevsr ddevsr added tests needed Pull requests that need tests docs needed Pull requests needing documentation write-ups and/or revisions. wrong branch PRs sent to wrong branch labels Mar 11, 2025
@ddevsr
Copy link
Collaborator

ddevsr commented Mar 11, 2025

Send new feature to branch 4.7

@paulbalandan
Copy link
Member

Closing as abandoned. If this is still needed, please open a new PR with tests. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs needed Pull requests needing documentation write-ups and/or revisions. tests needed Pull requests that need tests wrong branch PRs sent to wrong branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants