Skip to content

fix: anchor function not updating hostname when Config\App::$allowedHostnames is set #9492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: anchor function not updating hostname when Config\App::$allowedHostnames is set #9492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f9f384
Small fix for anchor function
devunee Mar 15, 2025
99b23a7
Update url_helper.php
devunee Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions system/Helpers/url_helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,10 @@ function index_page(?App $altConfig = null): string
* @param array|string $uri URI string or array of URI segments
* @param string $title The link title
* @param array|object|string $attributes Any attributes
* @param App|null $altConfig Alternate configuration to use
* @param App|null $config Alternate configuration to use
*/
function anchor($uri = '', string $title = '', $attributes = '', ?App $altConfig = null): string
function anchor($uri = '', string $title = '', $attributes = '', ?App $config = null): string
{
// use alternate config if provided, else default one
$config = $altConfig ?? config(App::class);

$siteUrl = is_array($uri) ? site_url($uri, null, $config) : (preg_match('#^(\w+:)?//#i', $uri) ? $uri : site_url($uri, null, $config));
// eliminate trailing slash
$siteUrl = rtrim($siteUrl, '/');
Expand All @@ -181,13 +178,10 @@ function anchor($uri = '', string $title = '', $attributes = '', ?App $altConfig
* @param string $uri the URL
* @param string $title the link title
* @param array|false|object|string $attributes any attributes
* @param App|null $altConfig Alternate configuration to use
* @param App|null $config Alternate configuration to use
*/
function anchor_popup($uri = '', string $title = '', $attributes = false, ?App $altConfig = null): string
function anchor_popup($uri = '', string $title = '', $attributes = false, ?App $config = null): string
{
// use alternate config if provided, else default one
$config = $altConfig ?? config(App::class);

$siteUrl = preg_match('#^(\w+:)?//#i', $uri) ? $uri : site_url($uri, null, $config);
$siteUrl = rtrim($siteUrl, '/');

Expand Down
Loading