Skip to content

fix: Stored XSS Vulnerability in Debug Toolbar (debugbar_time Paramete… #9497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: Stored XSS Vulnerability in Debug Toolbar (debugbar_time Paramete… #9497

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
524e10a
Fix Stored XSS Vulnerability in Debug Toolbar (debugbar_time Paramete…
shwet04 Mar 26, 2025
79df81f
Update Toolbar.php
shwet04 Mar 27, 2025
9766359
Update Toolbar.php
shwet04 Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions system/Debug/Toolbar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,16 +484,22 @@ public function respond()
if ($request->getGet('debugbar_time')) {
helper('security');

// Validate and sanitize the debugbar_time parameter -- ss
$debugbarTime = $request->getGet('debugbar_time');
if (! preg_match('/^\d+(\.\d+)?$/', $debugbarTime)) {
throw new InvalidArgumentException('Invalid debugbar_time parameter.');
}

// Negotiate the content-type to format the output
$format = $request->negotiate('media', ['text/html', 'application/json', 'application/xml']);
$format = explode('/', $format)[1];

$filename = sanitize_filename('debugbar_' . $request->getGet('debugbar_time'));
$filename = WRITEPATH . 'debugbar/' . $filename . '.json';

if (is_file($filename)) {
if (is_file($filename) && is_readable($filename)) {
// Show the toolbar if it exists
echo $this->format(file_get_contents($filename), $format);
echo htmlspecialchars($this->format(file_get_contents($filename), $format), ENT_QUOTES, 'UTF-8');

exit;
}
Expand Down