Skip to content

Conversation

@michalsn
Copy link
Member

@michalsn michalsn commented Apr 7, 2025

Description
This PR updates Rector to 2.0.11.

I was wondering if the rule RemoveDataProviderParamKeysRector does not reduce the readability of the tests, but it seems fine.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member

RemoveDataProviderParamKeysRector can be skipped as by preference, so register it to withSkip() is ok for that

@michalsn
Copy link
Member Author

michalsn commented Apr 7, 2025

Ok, I skipped the RemoveDataProviderParamKeysRector rule for now.

@samsonasik
Copy link
Member

Let's merge 👍 , thank you @michalsn @paulbalandan

@samsonasik samsonasik merged commit d33327c into codeigniter4:develop Apr 7, 2025
48 checks passed
@michalsn michalsn deleted the rector-update branch April 16, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants