refactor: deprecate redundant FileHandler cache methods
#9511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
deprecate-filehandler-cache-redundant-methods
branch
from
75e6462 to
84569d6
Compare
michalsn
approved these changes
Apr 11, 2025
|
Can include |
I'm sorry I don't understand your comment. Can you please elaborate? |
|
I mean just add the |
|
Sure. I'll change them later. |
paulbalandan
force-pushed
the
deprecate-filehandler-cache-redundant-methods
branch
from
84569d6 to
d6001a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecates the following protected methods of
FileHandleras being redundant from relatedfilesystem_helperfunctions:FileHandler::writeFile()FileHandler::deleteFiles()FileHandler::getDirFileInfo()FileHandler::getFileInfo()Checklist: