Skip to content

refactor: fix nullCoalesce.variable errors #9524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

refactor: fix nullCoalesce.variable errors #9524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee0580f
Fix nullCoalesce.variable errors.
warcooft Apr 13, 2025
34d4dfe
refactor: fix errors
warcooft Apr 14, 2025
cf7df3d
Suppress PHPStan warning
warcooft Apr 14, 2025
1ee1979
Update system/HTTP/RedirectResponse.php
warcooft Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions system/HTTP/RedirectResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ public function withInput()
{
$session = service('session');
$session->setFlashdata('_ci_old_input', [
'get' => $_GET ?? [],
'post' => $_POST ?? [],
'get' => $_GET ?? [], // @phpstan-ignore nullCoalesce.variable
'post' => $_POST ?? [], // @phpstan-ignore nullCoalesce.variable
]);

$this->withErrors();
Expand Down
3 changes: 1 addition & 2 deletions utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 3541 errors
# total 3539 errors
includes:
- argument.type.neon
- assign.propertyType.neon
Expand All @@ -22,7 +22,6 @@ includes:
- missingType.return.neon
- notIdentical.alwaysTrue.neon
- nullCoalesce.property.neon
- nullCoalesce.variable.neon
- offsetAccess.notFound.neon
- property.defaultValue.neon
- property.nonObject.neon
Expand Down
13 changes: 0 additions & 13 deletions utils/phpstan-baseline/nullCoalesce.variable.neon
View file
Open in desktop

This file was deleted.

Loading