Skip to content

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Apr 18, 2025

Description

  1. Save the model call from instantiating non class-strings.
  2. Added Tests\Support\Models namespace as known model namespaces.
    3. Adding Shield's namespace is not enough since PHPStan must know the class do exist, so we required shield as a dev dependency.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Apr 18, 2025
@paulbalandan
Copy link
Member Author

It seems the approach of requiring shield brings a lot of testing errors. Skipping that solution for now.

@paulbalandan paulbalandan merged commit 8c6da93 into codeigniter4:develop Apr 20, 2025
49 checks passed
@paulbalandan paulbalandan deleted the model-argument-type branch April 20, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants