Skip to content

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented May 17, 2025

Description
Fixes #7470

It seems the tests are being rate limited by GitHub. So, we instead use a mock curl request to prevent that. The tests do not care anyway of the contents of the queried files so it should be okay.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label May 17, 2025
@paulbalandan paulbalandan changed the title test: fix PublisherInputTest::testAddUri(s) failing due to rate lim… test: fix PublisherInputTest::testAddUri(s) failing due to rate limiting May 17, 2025
@paulbalandan paulbalandan merged commit 4fd4be1 into codeigniter4:develop May 18, 2025
47 checks passed
@paulbalandan paulbalandan deleted the publisher-rate-limit branch May 18, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PublisherInputTest::testAddUris failed in 4.4 branch

2 participants