Skip to content

refactor: fix notIdentical.alwaysTrue error #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

refactor: fix notIdentical.alwaysTrue error #9579

merged 2 commits into from
May 26, 2025

Conversation

@paulbalandan
Copy link
Member

Description
According to PHPStan, the null is already eliminated from $updateIndex in the check above.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label May 25, 2025
@paulbalandan paulbalandan merged commit edb04a7 into codeigniter4:develop May 26, 2025
49 checks passed
@paulbalandan paulbalandan deleted the always-true branch May 26, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan @michalsn