Skip to content

Conversation

@paulbalandan
Copy link
Member

Description
Fix errors in ResponseTrait.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jun 2, 2025
@datamweb
Copy link
Contributor

datamweb commented Jun 2, 2025

Fix errors in ResponseTrait.

Would it be possible to include the error link in the PR description?

@paulbalandan
Copy link
Member Author

Would it be possible to include the error link in the PR description?

I'm not sure how to effectively do that as there's 70 fixed phpstan errors, and the errors themselves can be seen in the deleted lines in the baselines.

@datamweb
Copy link
Contributor

datamweb commented Jun 2, 2025

Oh, I see — I thought those errors were already present in the GitHub Actions. I actually meant the link to the Actions runs.

@paulbalandan paulbalandan merged commit 88ec911 into codeigniter4:develop Jun 3, 2025
48 checks passed
@paulbalandan paulbalandan deleted the refactor-response-trait branch June 3, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants