Skip to content

fix: ensure make:test generates test files ending in Test #9636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 1 commit into from
Jul 15, 2025
Merged

fix: ensure make:test generates test files ending in Test #9636

samsonasik merged 1 commit into from
Jul 15, 2025

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Jul 15, 2025

Description
Ref: #9635 (review)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 15, 2025
@samsonasik samsonasik merged commit e52b915 into codeigniter4:develop Jul 15, 2025
50 checks passed
@samsonasik
Copy link
Member

samsonasik commented Jul 15, 2025

Thank you @paulbalandan

@paulbalandan paulbalandan deleted the make-test-suffix branch July 15, 2025 17:49
datamweb
datamweb reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulbalandan Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@datamweb datamweb datamweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulbalandan @samsonasik @michalsn @datamweb