Skip to content

fix: SMTP connection resource validation in Email class destructor #9648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 6 commits into from
Jul 30, 2025
Merged

fix: SMTP connection resource validation in Email class destructor #9648

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9099f86
fix: use is_resource() instead of null check for SMTP connection vali…
michalsn Jul 29, 2025
cc7f32f
update changelog
michalsn Jul 29, 2025
a577705
add the isSMTPConnected() method for a type-safe check
michalsn Jul 29, 2025
04f5b42
update the isSMTPConnected() method to also check for a false value
michalsn Jul 29, 2025
d32b857
update phpdoc for the SMTPConnect property
michalsn Jul 30, 2025
2e8091e
cs fix
michalsn Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/Email/Email.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,7 +2227,7 @@ protected function mimeTypes($ext = '')

public function __destruct()
{
if ($this->SMTPConnect !== null) {
if (is_resource($this->SMTPConnect)) {
try {
$this->sendCommand('quit');
} catch (ErrorException $e) {
Expand Down
1 change: 1 addition & 0 deletions user_guide_src/source/changelogs/v4.6.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Bugs Fixed
**********

- **Email:** Fixed a bug with CID check when building email attachments.
- **Email:** Fixed a bug with SMTP connection resource validation in the class destructor.

See the repo's
`CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_
Expand Down
Loading