Skip to content

refactor: remove curl_close has no effect since PHP 8.0 #9683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

refactor: remove curl_close has no effect since PHP 8.0 #9683

merged 1 commit into from
Aug 19, 2025

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Aug 14, 2025 •
edited
Loading

Description
Based on php/php-src#19451 and related to #9664

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik added enhancement PRs that improve existing functionalities refactor Pull requests that refactor code and removed enhancement PRs that improve existing functionalities labels Aug 14, 2025
michalsn
michalsn reviewed Aug 14, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we unset() it instead?

@ddevsr ddevsr mentioned this pull request Aug 14, 2025
Open
17 tasks
@michalsn michalsn added the 4.7 label Aug 14, 2025
@ddevsr ddevsr force-pushed the remove-curl-close branch from 733b87f to 0dc20e2 Compare August 19, 2025 10:29
@paulbalandan paulbalandan merged commit dfc34fd into codeigniter4:4.7 Aug 19, 2025
49 checks passed
@ddevsr ddevsr deleted the remove-curl-close branch August 25, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

4.7 refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddevsr @michalsn @paulbalandan @samsonasik