Skip to content

fix: compileOrderBy() method #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

fix: compileOrderBy() method #9697

merged 1 commit into from
Sep 4, 2025

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Sep 1, 2025

Description
This PR fixes a bug in BaseBuilder::compileOrderBy() where the method could overwrite QBOrderBy with a string instead of keeping it as an array. This caused type errors and made it impossible to append additional ORDER BY clauses.

Fixes #9696

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 1, 2025
@michalsn michalsn merged commit e6491a3 into codeigniter4:develop Sep 4, 2025
50 checks passed
@michalsn michalsn deleted the fix/orderBy branch September 4, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: orderBy method fails afrer and before calling getCompiledSelect

2 participants

@michalsn @paulbalandan