Skip to content

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 2, 2025

Description
See #9664

Reference:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added refactor Pull requests that refactor code 4.7 labels Sep 2, 2025
@ddevsr ddevsr mentioned this pull request Aug 28, 2025
17 tasks
@ddevsr ddevsr changed the title refactor: deprecated PHP 8.5 constant FILTER_DEFAULT for filter_*() refactor: deprecated PHP 8.5 constant FILTER_DEFAULT for filter_*() Sep 2, 2025
@samsonasik
Copy link
Member

@ddevsr looks good, could you create PR to rector-src as well at

https://github.com/rectorphp/rector-src/blob/main/config/set/php85.php

thank you.

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@samsonasik samsonasik merged commit d25f87b into codeigniter4:4.7 Sep 2, 2025
57 checks passed
@samsonasik
Copy link
Member

Thank you @ddevsr

@ddevsr ddevsr deleted the deprecated-filter-default branch September 2, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.7 refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants