fix: Remove check ext-json #9713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot remember where it was written but we can remove deprecated items in the next next minor version since those were deprecated. Since that was deprecated in 4.5 we can remove that in 4.7. |
neznaika0
force-pushed
the
fix/remove-check-json
branch
from
b2b6e8e to
2369207
Compare
paulbalandan
approved these changes
Sep 7, 2025
|
Why not remove all deprecated in |
|
because this applies to json. The others will be removed later. |
neznaika0
force-pushed
the
fix/remove-check-json
branch
from
2369207 to
02ac0bf
Compare
michalsn
reviewed
Sep 8, 2025
neznaika0
force-pushed
the
fix/remove-check-json
branch
from
02ac0bf to
d564e8f
Compare
|
Can you rebase again? I have pushed the latest changes from |
neznaika0
force-pushed
the
fix/remove-check-json
branch
from
353ed50 to
8691490
Compare
paulbalandan
approved these changes
Sep 13, 2025
michalsn
approved these changes
Sep 13, 2025
|
Thank you @neznaika0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JSON extension has been built in for a long time, starting with PHP 8.0.
Additional check in the deprecated method.
OFFTOPIC: Is there any way to ask questions outside of issues or the forum? They don't require a whole topic.
For example, "Is it possible to delete an outdated file bootstrap.php ?".
Checklist: