refactor: fix phpstan issues on magic properties #9728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datamweb
approved these changes
Sep 27, 2025
michalsn
approved these changes
Sep 27, 2025
paulbalandan
commented
Sep 27, 2025
| } | ||
|
|
||
| $sqlite = (! isset($this->password) || $this->password !== '') | ||
| $sqlite = ($this->password === null || $this->password !== '') |
There was a problem hiding this comment.
@michalsn quick question. should the RHS of this conditional be checking === ''?
There was a problem hiding this comment.
Good one... It's definitely a bug. It should be $this->password === ''
There was a problem hiding this comment.
I think this should be handled in a separate PR, so I'll hold off on the fix until this one is merged.
There was a problem hiding this comment.
Thanks for confirming. I think this is good to be merged. Merging.
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing some phpstan issues related to access of protected properties via magic
__get()and__isset().isset()so I just compared them tonullinstead.$sessionproperty with default empty array so I think the change is fine.Checklist: