Skip to content

refactor: Add @var array<> docblock on config properties on tests/ #9730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
+40 −52
Merged

refactor: Add @var array<> docblock on config properties on tests/ #9730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/system/Validation/CreditCardRulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
final class CreditCardRulesTest extends StrictCreditCardRulesTest
{
protected Validation $validation;

/**
* @var array<string, array<int|string, array<string, string>|string>>
*/
protected array $config = [
'ruleSets' => [
Rules::class,
Expand Down
4 changes: 4 additions & 0 deletions tests/system/Validation/FileRulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
final class FileRulesTest extends StrictFileRulesTest
{
protected Validation $validation;

/**
* @var array<string, array<int|string, array<string, string>|string>>
*/
protected array $config = [
'ruleSets' => [
Rules::class,
Expand Down
4 changes: 4 additions & 0 deletions tests/system/Validation/FormatRulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ class FormatRulesTest extends CIUnitTestCase
public const ALPHANUMERIC = 'abcdefghijklmnopqrstuvwxyzABCDEFGHLIJKLMNOPQRSTUVWXYZ0123456789';

protected Validation $validation;

/**
* @var array<string, array<int|string, array<string, string>|string>>
*/
protected array $config = [
'ruleSets' => [
Rules::class,
Expand Down
4 changes: 4 additions & 0 deletions tests/system/Validation/RulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
class RulesTest extends CIUnitTestCase
{
protected Validation $validation;

/**
* @var array<string, array<int|string, array<string, string>|string>>
*/
protected array $config = [
'ruleSets' => [
Rules::class,
Expand Down
4 changes: 4 additions & 0 deletions tests/system/Validation/StrictRules/CreditCardRulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
class CreditCardRulesTest extends CIUnitTestCase
{
protected Validation $validation;

/**
* @var array<string, array<int|string, array<string, string>|string>>
*/
protected array $config = [
'ruleSets' => [
Rules::class,
Expand Down
4 changes: 4 additions & 0 deletions tests/system/Validation/StrictRules/FileRulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
class FileRulesTest extends CIUnitTestCase
{
protected Validation $validation;

/**
* @var array<string, array<int|string, array<string, string>|string>>
*/
protected array $config = [
'ruleSets' => [
Rules::class,
Expand Down
3 changes: 3 additions & 0 deletions tests/system/Validation/StrictRules/FormatRulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
#[Group('Others')]
final class FormatRulesTest extends TraditionalFormatRulesTest
{
/**
* @var array<string, array<int|string, array<string, string>|string>>
*/
protected array $config = [
'ruleSets' => [
Rules::class,
Expand Down
4 changes: 4 additions & 0 deletions tests/system/Validation/StrictRules/RulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
final class RulesTest extends TraditionalRulesTest
{
protected Validation $validation;

/**
* @var array<string, array<int|string, array<string, string>|string>>
*/
protected array $config = [
'ruleSets' => [
Rules::class,
Expand Down
3 changes: 3 additions & 0 deletions tests/system/Validation/StrictRules/ValidationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
#[Group('Others')]
final class ValidationTest extends TraditionalValidationTest
{
/**
* @var array<string, array<int|string, array<string, array<string, string>|string>|string>|string>
*/
protected static array $config = [
'ruleSets' => [
Rules::class,
Expand Down
4 changes: 4 additions & 0 deletions tests/system/Validation/ValidationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@
class ValidationTest extends CIUnitTestCase
{
protected Validation $validation;

/**
* @var array<string, array<int|string, array<string, array<string, string>|string>|string>|string>
*/
protected static array $config = [
'ruleSets' => [
Rules::class,
Expand Down
2 changes: 1 addition & 1 deletion utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 2800 errors
# total 2790 errors

includes:
- argument.type.neon
Expand Down
52 changes: 1 addition & 51 deletions utils/phpstan-baseline/missingType.iterableValue.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 1388 errors
# total 1378 errors

parameters:
ignoreErrors:
Expand Down Expand Up @@ -6362,16 +6362,6 @@ parameters:
count: 1
path: ../../tests/system/Throttle/ThrottleTest.php

-
message: '#^Property CodeIgniter\\Validation\\CreditCardRulesTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/CreditCardRulesTest.php

-
message: '#^Property CodeIgniter\\Validation\\FileRulesTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/FileRulesTest.php

-
message: '#^Method CodeIgniter\\Validation\\FormatRulesTest\:\:alphaNumericProvider\(\) return type has no value type specified in iterable type iterable\.$#'
count: 1
Expand Down Expand Up @@ -6477,11 +6467,6 @@ parameters:
count: 1
path: ../../tests/system/Validation/FormatRulesTest.php

-
message: '#^Property CodeIgniter\\Validation\\FormatRulesTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/FormatRulesTest.php

-
message: '#^Method CodeIgniter\\Validation\\RulesTest\:\:provideDiffers\(\) return type has no value type specified in iterable type iterable\.$#'
count: 1
Expand Down Expand Up @@ -6662,11 +6647,6 @@ parameters:
count: 1
path: ../../tests/system/Validation/RulesTest.php

-
message: '#^Property CodeIgniter\\Validation\\RulesTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/RulesTest.php

-
message: '#^Method CodeIgniter\\Validation\\StrictRules\\CreditCardRulesTest\:\:calculateLuhnChecksum\(\) has parameter \$digits with no value type specified in iterable type array\.$#'
count: 1
Expand All @@ -6677,16 +6657,6 @@ parameters:
count: 1
path: ../../tests/system/Validation/StrictRules/CreditCardRulesTest.php

-
message: '#^Property CodeIgniter\\Validation\\StrictRules\\CreditCardRulesTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/StrictRules/CreditCardRulesTest.php

-
message: '#^Property CodeIgniter\\Validation\\StrictRules\\FileRulesTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/StrictRules/FileRulesTest.php

-
message: '#^Method CodeIgniter\\Validation\\StrictRules\\FormatRulesTest\:\:provideAlphaSpace\(\) return type has no value type specified in iterable type iterable\.$#'
count: 1
Expand All @@ -6697,11 +6667,6 @@ parameters:
count: 1
path: ../../tests/system/Validation/StrictRules/FormatRulesTest.php

-
message: '#^Property CodeIgniter\\Validation\\StrictRules\\FormatRulesTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/StrictRules/FormatRulesTest.php

-
message: '#^Method CodeIgniter\\Validation\\StrictRules\\RulesTest\:\:provideDiffers\(\) return type has no value type specified in iterable type iterable\.$#'
count: 1
Expand Down Expand Up @@ -6757,16 +6722,6 @@ parameters:
count: 1
path: ../../tests/system/Validation/StrictRules/RulesTest.php

-
message: '#^Property CodeIgniter\\Validation\\StrictRules\\RulesTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/StrictRules/RulesTest.php

-
message: '#^Property CodeIgniter\\Validation\\StrictRules\\ValidationTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/StrictRules/ValidationTest.php

-
message: '#^Method CodeIgniter\\Validation\\ValidationTest\:\:placeholderReplacementResultDetermination\(\) has parameter \$data with no value type specified in iterable type array\.$#'
count: 1
Expand Down Expand Up @@ -6862,11 +6817,6 @@ parameters:
count: 1
path: ../../tests/system/Validation/ValidationTest.php

-
message: '#^Property CodeIgniter\\Validation\\ValidationTest\:\:\$config type has no value type specified in iterable type array\.$#'
count: 1
path: ../../tests/system/Validation/ValidationTest.php

-
message: '#^Method CodeIgniter\\View\\ParserTest\:\:provideEscHandling\(\) return type has no value type specified in iterable type iterable\.$#'
count: 1
Expand Down
Loading